This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Use target MEM's alias set in store_constructor (PR middle-end/37730)
- From: "Diego Novillo" <dnovillo at google dot com>
- To: "Jakub Jelinek" <jakub at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Oct 2008 08:13:30 -0400
- Subject: Re: [PATCH] Use target MEM's alias set in store_constructor (PR middle-end/37730)
- References: <20081030002129.GO14706@tyan-ft48-01.lab.bos.redhat.com>
2008/10/29 Jakub Jelinek <jakub@redhat.com>:
> This patch fixes it by always using target's MEM_ALIAS_SET if target is a
> MEM. Another possibility could be e.g.:
> alias = get_aliase_set (elttype);
> if (MEM_P (target)
> && !alias_sets_conflict_p (alias, MEM_ALIAS_SET (target)))
> {
> gcc_assert (TREE_CODE (elttype) == POINTER_TYPE
> && MEM_ALIAS_SET (target) == get_alias_set (ptr_type_node));
> alias = MEM_ALIAS_SET (target);
> }
Could be, but this patch seems simpler.
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
>
> 2008-10-29 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/37730
> * expr.c (store_constructor): Fro vectors, if target is a MEM, use
> target's MEM_ALIAS_SET instead of elttype alias set.
s/Fro/For/
OK otherwise.