This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto][patch] Use decl uid instead of node uid in ipa-pure-const


On Thu, Oct 23, 2008 at 8:29 PM, Daniel Berlin <dberlin@dberlin.org> wrote:
> Why is inliner changing pre-existing nodeids?
> That is going to screw with more than just ipa-pure-const.

Martin added reclaiming of old UIDs to make them more dense for vectors
indexed by them (for ipa-cp I think).

Richard.

>
> On Thu, Oct 23, 2008 at 8:57 AM, Rafael Espindola <espindola@google.com> wrote:
>> Pure const  works with functions. Switching to decl_id avoids some
>> cases where it gets confused with the inliner changing node ids.
>>
>> This fixes libgomp.c++/for-4.C
>>
>> 2008-10-23 Rafael Espindola  <espindola@google.com>
>>
>>        * ipa-pure-const.c (node_duplication_hook_holder,
>>        node_removal_hook_holder): Remove.
>>        (get_function_state, set_function_state): Use DECL_UID.
>>        (duplicate_node_data, remove_node_data): Remove.
>>        (generate_summary): Don't use the removed functions. Iterate over
>>        funct_state_vec and free the states.
>>
>> Cheers,
>> --
>> Rafael Avila de Espindola
>>
>> Google | Gordon House | Barrow Street | Dublin 4 | Ireland
>> Registered in Dublin, Ireland | Registration Number: 368047
>>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]