Re: [PATCH] SPU: Use FRAME_GROWS_DOWNWARD

[<trevor_smigiel at playstation dot sony dot com>]

Stefan,

These changes look good.  This is OK for mainline.

Trevor

* Stefan Schulze Frielinghaus <XXSCHULZ@de.ibm.com> [2008-10-23 11:55]:
> gcc-patches-owner@gcc.gnu.org wrote on 10/21/2008 09:42:56 PM:
> 
> > <trevor_smigiel@playstation.sony.com>
> > Sent by: gcc-patches-owner@gcc.gnu.org
> [...]
> > In the "stack_protect_set" and "stack_protect_test_si" patterns, the
> > type attribute should be multi1. This indicates that the first
> > instruction is in the odd pipeline, which allows slightly better
> > scheduling of these patterns.
> 
> Sure, load/store always computes in pipe 1. Changed
> 
> >
> > In "stack_protect_test_si", shouldn't the "+r" of the first operand be
> > "=&r"?  Also, please change "register_operand" to "spu_reg_operand".
> > Based on the code, it is not necessary now, but it protects us from
> > possible issues in the future.
> 
> Changed.
> 
> >
> > I'm a little suspicious of the memory predicates, constraints, and the
> > hard coded load/store instructions.  How do we know that the memory rtl
> > will always match the hard coded instructions?
> 
> Right. Changed to %p and spu_mem_operand.
> 
> >
> > How did you compare the test suite results?  Did you use
> > contrib/compare_tests?  Or just compare the numbers/statistics printed
> > at the end?  (Use compare_tests.)
> 
> compare_tests result:
> 
> New tests that PASS::
> 
> gcc.dg/pr34225.c (test for excess errors)
> 
> This test passes because it needs -fstack-protector.
> 
> New patch tested with same results as previous patch.
> 
> (See attached file: spu.patch)
> Mit freundlichen Gruessen / Kind regards
> 
> Stefan Schulze Frielinghaus
> 
> IBM Systems & Technology Group, Systems Software Development
> SW Linux on Cell BE Development & Evaluation
> -------------------------------------------------------------------------------
> 
> IBM Deutschland
> Schoenaicher Str. 220
> 71032 Boeblingen
> Phone: ++49-(0)7031-16-2173
> E-Mail: xxschulz@de.ibm.com
> -------------------------------------------------------------------------------
> 
> IBM Deutschland Research & Development GmbH
> Vorsitzender des Aufsichtsrats: Martin Jetter
> Geschaeftsfuehrung: Herbert Kircher
> Sitz der Gesellschaft: Boeblingen
> Registergericht: Amtsgericht Stuttgart, HRB 243294