This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch][graphite] Fix flags set by split_block

From: Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>
To: Richard Guenther <rguenther at suse dot de>
Cc: Sebastian Pop <sebpop at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 22 Oct 2008 22:28:13 +0200
Subject: Re: [patch][graphite] Fix flags set by split_block
References: <cb9d34b20810211655l126bdf8brd57f7d9747303090@mail.gmail.com> <alpine.LNX.1.10.0810221201480.3746@zhemvz.fhfr.qr>

Hi,

> > The following bug occurs at least 7 times in spec2k6:
> > 
> > 959.c:28: error: edge from 17 to 57 should be marked irreducible
> > 959.c:28: error: basic block 57 should be marked irreducible
> > 959.c:28: error: edge from 34 to 53 should be marked irreducible
> > 959.c:28: error: basic block 53 should be marked irreducible
> > 
> > split_block_after_labels does not correctly update the flags for the
> > edges and bbs it creates.  Is this patch correct, or should these
> > flags be set by split_block instead?
> 
> I think split_block should do this instead (after all, split_edge
> does).

yes, it should,

Zdenek

References:
- [patch][graphite] Fix flags set by split_block
  - From: Sebastian Pop
- Re: [patch][graphite] Fix flags set by split_block
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]