This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Clean global object source of file function name (PR target/35485)

David Edelsohn wrote:

>         PR target/35485
>         * tree.c (get_file_function_name): Clean first_global_object_name.

This is OK, but I think it would be slightly cleaner to move the
clean_symbol_name call out of the three if/else cases and put it right
before the alloca call.  That would make obvious that we always clean
the name before allocating the final symbol.  If that makes sense to
you, that change is pre-approved.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]