This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: "Danny Smith" <dansmister at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>, "Kai Tietz" <ktietz70 at googlemail dot com>, NightStrike <nightstrike at gmail dot com>
- Date: Sat, 11 Oct 2008 15:09:40 +0200
- Subject: Re: [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build
Hello Danny,
"Danny Smith" <dansmister@gmail.com> wrote on 11.10.2008 02:56:55:
> On Fri, Oct 10, 2008 at 11:37 PM, Kai Tietz <Kai.Tietz@onevision.com>
wrote:
> > Hello Dany,
> >
> > I updated the patch to prevent the none-prototyped warning, that Aaron
> > detected.
> > As we talked, I tested this patch for 32-bit and 64-bit mingw. I saw
no
> > new failure or regressions reasoned by this patch.
> >
> > ChangeLog
> >
> > 2008-10-10 Kai Tietz <kai.tietz@onevision.com>
> >
> > Fix PR/25502
> > * c-format.c (convert_format_name_to_system_name): Use
> > TARGET_OVERRIDES_FORMAT_INIT.
> > * config.gcc (extra_options): Add for mingw targets mingw.opt.
> > * config/i386/mingw.opt: New.
> > * config/i386/mingw32.h (TARGET_OVERRIDES_FORMAT_INIT): New.
> > * config/i386/msformat-c.c (TARGET_OVERRIDES_FORMAT_INIT): New.
> > (ms_printf_length_specs): Removed const specifier.
> > * doc/tm.texi (TARGET_OVERRIDES_FORMAT_INIT): New.
> >
> > Is this patch ok for apply?
>
> How did you bootstrap mingw32. Since IRA merge, I have been unable to
> bootstrap mingw32 because of miscompilation of cp/pt.c. Did you use
> -fno-ira in CFLAGS?
>
> I realize that the bootstrap problem has nothing to do with your
> patch, but I am curious as to how you tested.
For w64 the bootstrap is still working. You are right, that for w32 I used
the -fno-ira flag, because otherwise bootstrap fails for it.
Kai
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.