This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [lto][patch] Remove nodes for extern inline function before writing to disk

From: "Rafael Espindola" <espindola at google dot com>
To: "Diego Novillo" <dnovillo at google dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 9 Oct 2008 14:52:55 +0100
Subject: Re: [lto][patch] Remove nodes for extern inline function before writing to disk
References: <38a0d8450810090623j63452261mf64f64601c112efd@mail.gmail.com> <b798aad50810090629g17a49434t3756c9d98d1f5e51@mail.gmail.com>

> No need to create another pass for this.  Just call
> cgraph_remove_unreachable_nodes from pass_ipa_free_lang_specifics.  OK
> with that change.

pass_ipa_free_lang_specifics runs too early. If we remove the bodies
there, programs that have extern inline functions and assume they are
inlined will fail. We actually test for that on the testsuite (forgot
the test number).


> Diego.
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047

Follow-Ups:
- Re: [lto][patch] Remove nodes for extern inline function before writing to disk
  - From: Diego Novillo

References:
- [lto][patch] Remove nodes for extern inline function before writing to disk
  - From: Rafael Espindola
- Re: [lto][patch] Remove nodes for extern inline function before writing to disk
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]