This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR fortran/35846: ICE on character array constructor


Tobias Burnus wrote:
Daniel Kraft wrote:
This is fixed with the new patch and your test compiles fine, too, and
outputs the expected values.

The new patch is just regression testing.  What do you think about
this one?  Or do you think the way this patch works is completely
wrong and I should try to find another solution?  I just thought it
would be the best idea to reuse the existing logic in
gfc_conv_string_length for
gfc_conv_expr_descriptor/gfc_conv_string_length.
I think this solution is ok. Thus: OK for the trunk. Especially as this
is only an ICE and not a wrong-code bug, I think backporting is not needed.

Committed as revision 140529 to trunk. Thanks for your review and your hint!


Yours,
Daniel

--
Done:     Arc-Bar-Cav-Sam-Val-Wiz, Dwa-Elf-Gno-Hum-Orc, Law-Neu-Cha, Fem-Mal
To go:    Hea-Kni-Mon-Pri-Ran-Rog-Tou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]