This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[vta,vta4.3,trunk?] don't compute DECL_ASSEMBLER_NAME because of debugging dumps
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Thu, 11 Sep 2008 03:43:21 -0300
- Subject: [vta,vta4.3,trunk?] don't compute DECL_ASSEMBLER_NAME because of debugging dumps
Enabling debug dumps shouldn't modify the generated code. In
particular, it shouldn't cause DECL_ASSEMBLER_NAME to be computed,
which may cause templates to be instantiated. Just imagine how fun it
was to debug this problem, that went away when I enabled debug dumps!
:-)
Ok for trunk?
for gcc/ChangeLog.vta
from Alexandre Oliva <aoliva@redhat.com>
* c-gimplify.c (c_genericize): Don't refer to DECL_ASSEMBLER_NAME
before ensuring it's already computed.
Index: gcc/c-gimplify.c
===================================================================
--- gcc/c-gimplify.c.orig 2008-09-05 03:09:12.000000000 -0300
+++ gcc/c-gimplify.c 2008-09-05 03:10:02.000000000 -0300
@@ -2,7 +2,8 @@
by the C-based front ends. The structure of gimplified, or
language-independent, trees is dictated by the grammar described in this
file.
- Copyright (C) 2002, 2003, 2004, 2005, 2007 Free Software Foundation, Inc.
+ Copyright (C) 2002, 2003, 2004, 2005, 2007, 2008
+ Free Software Foundation, Inc.
Lowering of expressions contributed by Sebastian Pop <s.pop@laposte.net>
Re-written to support lowering of whole function trees, documentation
and miscellaneous cleanups by Diego Novillo <dnovillo@redhat.com>
@@ -87,7 +88,8 @@ c_genericize (tree fndecl)
fprintf (dump_orig, "\n;; Function %s",
lang_hooks.decl_printable_name (fndecl, 2));
fprintf (dump_orig, " (%s)\n",
- IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (fndecl)));
+ !DECL_ASSEMBLER_NAME_SET_P (fndecl) ? NULL
+ : IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (fndecl)));
fprintf (dump_orig, ";; enabled by -%s\n", dump_flag_name (TDI_original));
fprintf (dump_orig, "\n");
--
Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}
FSFLA Board Member ÂSÃ Libre! => http://www.fsfla.org/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}