This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3] c++0x <mutex> and <condition_variable>
On Wed, Sep 3, 2008 at 6:30 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Andreas Tobler wrote:
>>
>> Paolo Carlini wrote:
>>>
>>> Chris Fairles wrote:
>>>>
>>>> Missed a few explicit bool casts.
>>>>
>>>
>>> Committed after a multilib build on x86_64-linux.
>>
>> Breaks bootstrap on *-*-darwin*.
>
> Sorry Andreas. I'm committing the below should be enough to restore
> bootstrap on darwin (actually, earlier today wanted to regtest on darwin
> too, but bootstrap was broken for other reasons ;)
>
> Anyway, Chris, I confirm that we need something more fine-grained on the
> library side, disabling only the features relying on _POSIX_TIMERS. Better
> would be allowing also for the cases of _POSIX_TIMERS == 0 and then check at
> run-time if the feature is actually available, per the usual Posix rules.
>
> Paolo.
>
> //////////////////
>
> 2008-09-03 Paolo Carlini <paolo.carlini@oracle.com>
>
> * acinclude.m4 ([GLIBCXX_CHECK_GTHREADS]): Check _POSIX_TIMERS too.
> * configure: Regenerate.
>
> Index: acinclude.m4
> ===================================================================
> *** acinclude.m4 (revision 139944)
> --- acinclude.m4 (working copy)
> *************** AC_DEFUN([GLIBCXX_CHECK_GTHREADS], [
> *** 2843,2849 ****
>
> AC_TRY_COMPILE([#include "gthr.h"],
> [
> ! #ifndef __GTHREADS_CXX0X
> #error
> #endif
> ], [ac_has_gthreads=yes], [ac_has_gthreads=no])
> --- 2843,2849 ----
>
> AC_TRY_COMPILE([#include "gthr.h"],
> [
> ! #if (!defined(__GTHREADS_CXX0X) || _POSIX_TIMERS <= 0)
> #error
> #endif
> ], [ac_has_gthreads=yes], [ac_has_gthreads=no])
>
>
Should it not be _POSIX_TIMEOUTS ;) (_POSIX_TIMERS is for
clock_gettime, nanosleep et. al., _POSIX_TIMEOUTS is for timedlock).
Chris