This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Don't allocate space for SSE reg in reg save area if SSE is disabled


On Fri, Aug 29, 2008 at 09:59:42AM +0200, Richard Guenther wrote:
> On Thu, Aug 28, 2008 at 7:23 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> > On Thu, Aug 28, 2008 at 10:04:49AM -0700, H.J. Lu wrote:
> >> On Thu, Aug 28, 2008 at 09:57:45AM -0700, H.J. Lu wrote:
> >> >
> >> > We are allocating space for SSE reg in reg save area even if SSE is
> >> > disabled. -mno-sse is used on Linux kernel.  Here is patch to avoid it.
> >> > OK for trunk and 4.3?
> >> >
> >>
> >> Here is the updated patch with some optimization.  OK for  trunk and
> >> 4.3?
> >
> > Does this actually work, even if e.g. there are no integer, but some
> > floating point va_args?
> 
> In addition I think you need to say that -mno-sse changes the ABI and
> calling vaargs functions across CUs compiled with different -mno-sse
> setting is not supported?  If this is true then I think a new option
> controlling this should be added and -mno-sse shouldn't be overloaded
> with this.

You will get a message if psABI is changed by -mno-sse. See
gcc.target/i386/amd64-abi-1.c.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]