Re: ARM section anchors

["Andrew Pinski" <pinskia at gmail dot com>]

On Thu, Aug 28, 2008 at 11:01 AM, Paul Brook <paul@codesourcery.com> wrote:
> That patch below enables section anchors for ARM targets.
>
> Tested on arm-none-eabi
> Applied to svn trunk.

> +/* Set default optimization options.  */
> +void
> +arm_optimization_options (int level, int size ATTRIBUTE_UNUSED)
> +{
> +  /* Enable section anchors by default at -O1 or higher.  */
> +  flag_section_anchors = (level > 0 ? 1 : 0);
> +}
I notice two things:
First this enables section anchors for objective-C, has the front-end
been fixed?  You said you tested on arm-eabi (and that enables
objective-C by default and I know libobjc has been ported to that
target) so what languages did you test?

Second this enables section anchors for -fno-loplevel-reorder, I
thought we decided that this should not be enabled for that.

This is what the rs6000 back-end does to fix those two issues, I think
the ARM back-end should do the same:
  /* Enable section anchors by default.
     Skip section anchors for Objective C and Objective C++
     until front-ends fixed.
     Do not enable section anchors without toplevel reorder.  */
  if (!TARGET_MACHO
      && lang_hooks.name[4] != 'O'
      && flag_toplevel_reorder != 0)
    flag_section_anchors = 2;

Thanks,
Andrew Pinski