This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: named address space support (2/2: SPU backend)
- From: Ben Elliston <bje at au1 dot ibm dot com>
- To: Trevor_Smigiel at playstation dot sony dot com
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, andrew_pinski at playstation dot sony dot com, David Edelsohn <dje at watson dot ibm dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Thu, 28 Aug 2008 14:24:36 +1000
- Subject: Re: PATCH: named address space support (2/2: SPU backend)
- References: <1219295660.17217.9.camel@helios> <20080828032054.GP27746@playstation.sony.com>
Hi Trevor
Thanks for the review!
On Wed, 2008-08-27 at 20:20 -0700, Trevor_Smigiel@playstation.sony.com
wrote:
> In t-spu-elf, I'm confused by the new targets. Are they supposed to be
> multilib? If so, shouldn't they use $(T) instead of having duplicate
> rules? And include $(MULTILIB_CFLAGS). For example, change
You learn something new about GCC every day. :-) Fixed.
> -In spu_cache.h, can you include the "unlimited exception" versions of
> the GNU license exceptions? I've seen it in other headers. We don't
> like the "compiled with GCC" part of the current exception used.
The license stated in spu_cache.h is the same as spu_mfcio.h and other
installed headers. I'm quite sure I am in no position to alter the
licenses on any of the headers without FSF/SC approval.
> Otherwise it looks ok, assuming there are no major changes after the
> first part of the patch is accepted.
Thanks. There are some minimal changes, but will run them past you
again later today (it won't be too different).
Cheers, Ben