This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Infrastructure to let ipcp to remove unused arguments from calls


On Wed, Aug 27, 2008 at 11:39, Jan Hubicka <jh@suse.cz> wrote:

> +
> +  /* This is a new type, not a copy of an old type.  Need to reassociate
> +     variants.  We can handle everything except the main variant lazily.  */
> +  t = TYPE_MAIN_VARIANT (orig_type);

Why not use build_variant_type_copy() here?

>  }
>
> +/* Build call same as STMT but skipping arguments ARGS_TO_SKIP.  */
> +gimple

Blank line after comment.

> +gimple_call_skip_args (gimple stmt, bitmap args_to_skip)

This is a copy operation, so I think a better name would be
gimple_copy_call_skip_args() or something along those lines.



Looks fine otherwise.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]