Re: Second attempt at fixing reloading of even-only registers

[Mark Mitchell <mark at codesourcery dot com>]

Richard Sandiford wrote:

>>>    http://gcc.gnu.org/ml/gcc-patches/2008-07/msg01688.html
>>> I wasn't sure where to put the new function.  On the one hand it has
>>> "simplify" in the name, so simplify-rtx.c would seem a natural home.
>>> On the other hand, the new function has a similar interface and function
>>> to rtlanal.c routines like subreg_regno_offset.
>> I'd probably have used "get_" instead of "simplify", which makes your
>> choice of rtlanal.c seem more logical. :-)  You're not so much
>> simplifying something as just working out what register you mean.  But,
>> that's just semantics; either name is fine.
> 
> Hmm.  The problem here is that we also have plain "subreg_regno",
> so having "get_subreg_regno" might be a bit confusing.
> 
> The first cut actually had "subreg_maybe_regno", but I renamed
> it when I decided to steal the simplify_subreg logic.  Would that
> be better?

I don't think so; let's just go with what you've already got.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713