Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c

["Rafael Espindola" <espindola at google dot com>]

>> Is there something I can do to help?
>
> Yes, there's a related change in revision 138310.  From the
> mailing list conversation it looks like it's just papering over
> the output_operand machinery not being able to "catch" all
> symbol_refs.  This should be fixed by my "take 4" patch.  I'd
> just like to verify that with the "original" pair of eyes.

I am not very familiar with RTL, but I like your idea of using for_each_rtx.

> But, all of this seems just a hack anyway, and the
> assemble_external calls should be only in the "expand" pass; not
> in front-ends nor in the back-end (varasm.c, final.c).  If you
> could fix *that*, it'd be nice.

I think I agree with Zack on this one:
http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00491.html

The best place to know if we need an external declaration is when we
output an use of it. Doesn't the use of for_each_rtx solves your
concern about playing target-specific tricks?

I might be able to help remove some FE calls to assemble_external.

> brgds, H-P
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047