This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR36705: Procedure pointers with attributes statements
- From: Tobias Burnus <burnus at net-b dot de>
- To: Janus Weil <jaydub66 at googlemail dot com>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 14 Aug 2008 21:01:44 +0200
- Subject: Re: [Patch, Fortran] PR36705: Procedure pointers with attributes statements
- References: <854832d40808141118k564418eah9ad6047017906ecc@mail.gmail.com>
Janus Weil wrote:
Regtested on i686-pc-linux-gnu with no failures. Ok for trunk?
OK. Thanks for the patch.
Is it only me who finds the preposion "in" strange in:
+ gfc_error ("PROCEDURE attribute conflicts with SAVE attribute "
+ "in '%s' at %L", sym->name, &sym->declared_at);
+ return FAILURE;
I know you only copied that part but also for
dimension :: m(5)
1
Error: PROGRAM attribute conflicts with DIMENSION attribute in 'm' at (1)
I would not use "in" but "for". Unless my Sprachgefühl misleads me, I
would therefore use "for" (both at symbol.c and in resolve.c).
Any native speaker around which can confirm/dispprove this using his/her
innate sense of the English language?
Tobias
2008-08-14 Janus Weil <janus@gcc.gnu.org>
PR fortran/36705
* symbol.c (check_conflict): Move conflict checks for (procedure,save)
and (procedure,intent) to resolve_fl_procedure.
* resolve.c (resolve_fl_procedure): Ditto.
2008-08-14 Janus Weil <janus@gcc.gnu.org>
PR fortran/36705
* gfortran.dg/argument_checking_7.f90: Modified.
* gfortran.dg/conflicts.f90: Modified.
* gfortran.dg/proc_decl_1.f90: Modified.
* gfortran.dg/proc_ptr_9.f90: New.