This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [vta,trunk?] inlining gen_rtvec_v into gen_rtvec warns
On Tue, Aug 12, 2008 at 7:19 PM, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Aug 12, 2008, "Richard Guenther" <richard.guenther@gmail.com> wrote:
>
>> 2008/8/12 Alexandre Oliva <aoliva@redhat.com>:
>>> Bootstrapping with -O3 on x86/64? causes gen_rtvec_v() to be inlined
>>> into gen_rtvec(). This in turns causes the test for n == 0, already
>>> performed in the caller, to be warned about, since it's always false.
>>> I don't think it is appropriate to warn in this case, but this patches
>>> permits bootstrap with -O3 to succeed.
>
>> Why not fix gen_rtvec instead to not allocate the temporary array
>> on the stack?
>
> Err... I don't understand how the allocation of the temporary array
> on the stack relates with the warning about the redundant (after
> inlining) test for n == 0. Can you please elaborate?
See paolos patch. You no longer call gen_rtvec_v.
Richard.