Re: [PATCH v2] ada: Simplify code while building boolean expression

[Robert Dewar <dewar at adacore dot com>]

Arnaud Charlet wrote:
> > | (This v2 further simplifies the code by converting only the
> > | result to "Boolean")
> > | 
> > | Simplify code by building
> > | 
> > |   if Boolean (B'First and B'Last) then
> > | 
> > | instead of
> > | 
> > |   if B'First = BT (True) and B'Last = BT (True) then
> > | 
> > | in Silly_Boolean_Array_Xor_Test.
> >
> > Arnaud, I'm not sure about this one: if B is defined as a null range
> > (True..False), then "B'First and B'Last" doesn't fall into B domain. The
> > first version may be better in fact, I'll let you choose.
>
> Well for sure you are not helping the review process by sending many
> follow ups and changes.
>
> I'll see what I can do.
>
> Arno

It's a bit tricky indeed, I will review this carefully, it is of
course a very non-critical piece of code so we want to be sure
not to introduce any regression!