This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Function specific options: Fix regressions, C++ support
- From: "Richard Guenther" <richard dot guenther at gmail dot com>
- To: "Michael Meissner" <gnu at the-meissners dot org>, rguenther at suse dot de, jh at suse dot cz, jason at redhat dot com, mark at codesourcery dot com, nathan at codesourcery dot com, gcc-patches at gcc dot gnu dot org
- Date: Tue, 5 Aug 2008 10:46:41 +0200
- Subject: Re: [PATCH] Function specific options: Fix regressions, C++ support
- References: <20080805035909.GA25370@tiktok.the-meissners.org>
On Tue, Aug 5, 2008 at 5:59 AM, Michael Meissner <gnu@the-meissners.org> wrote:
> This patch should fix some of the problems that have been noted with function
> specific option support. I 3 staged an x86_64 target and ran make check.
> There was one regression (pr36997), which is a new test, that fails under -m32
> because the __builtin_ia32_paddq is not defined without the -msse2 option and I
> fixed the test.
>
> The changes in this patch are:
>
> 1) I disabled hot/cold functions from changing the optimization level by
> default. This should fix the Spec regression that Richard noticed. It would
> be helpful if this patch could be tested to make sure it does fix the
> regression before I commit it.
I applied your earlier patch to our SPEC 2k6 tester and that didn't make
any difference. So it must be another change between revs 138121 and
138141 (that _must_ be the drop unit-at-a-time mode change), or
maybe 138171 (that includes your changes and the DECL_INLINE change).
Thanks,
Richard.