RE: patch for long lines in makefile

[Jay <jayk123 at hotmail dot com>]

Ralf, I was hoping to skate by via being a small change, but yeah (ie: no papers to sign).

I'll read that again/more, and test other platforms.

> That being said, you can probably work around this issue by modifying
> $srcdir/gcc/Makefile.in instead (of course, unless you need to change
> any of the substitutions, that is).

Exactly. This IS a substitution, a long one.
But actually, it might be simpler to make it a per-language substitution.
With newlines in the original Makefile.in like you say, and no newlines in the substitution.
ie (from memory):

gtfiles=\
 @c_gtfiles@ \ 
 @cpp_gtfiles@ \
 @ada_gtfiles@ \
 @java_gtfiles@ \
 etc.

instead of the big current (from memory):

gtfiles=\
 @gtfiles@ \ 

 That doesn't wrap "as much", but enough for me. 

>  Sorry, but the way Autoconf 2.59 works, this is not going to work: 
>  
> | config.status: creating as 
> | sed: file ./confstatV21441/subs-4.sed line 51: unterminated `s' command 

Right, I saw this error MANY times while developing/testing the patch.
Notice how many slashes I had to put in. :)
I guess it might not be supported, but does work, with enough effort. ?

I finally arrived at something that works -- at least on Cygwin.

I will have to try Linux, Solaris, MacOS X though, granted.

> the classical text utils (sed, awk, ...) need to read the Makefile text 
> at all, but typically, some vendor-provided ones work well only with  
> text files (i.e., files without long lines). 

Nothing that /must/ read the files is broken.
  The file is written by configure, read by GNU make. Probably not much else.
 But my editor..

I have to look up those terms..
"top posting" is probably replying with new text on the top and old text on the bottom,
what the email programs push you toward, but is hard to read..

And yeah, I specifically installed Autoconf 2.59 so I could regen the files without
extra churn from Autoconf changing.
I DID test the patch, though only on Cygwin (so far).
It's quite difficult to get it working just by sight, what with all the backslashes required...

Given that I did get my patch through Autoconf 2.59 on Cygwin, doesn't seem as bad?
Again, I'll have to test on Linux, MacosX, Solaris and maybe *BSD.
(I'm not setup at all for FreeBSD and NetBSD. I am setup for OpenBSD, but it seems somewhat
orphaned by gcc currently. I've got MacosX/powerpc, Solaris/sparc64, Linux/x86, rarely
Linux/amd64, I plan to bring up more but this is all for the time being.)

Thanks,
 - Jay

> Date: Fri, 1 Aug 2008 07:58:33 +0200
> From: Ralf.Wildenhues@gmx.de
> To: jayk123@hotmail.com
> CC: gcc-patches@gcc.gnu.org
> Subject: Re: FW: patch for long lines in makefile
>
> Hello Jay,
>
> Thanks for bringing this issue up!