This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]: Get IPA PTA working again

From: "Daniel Berlin" <dberlin at dberlin dot org>
To: "Jan Hubicka" <jh at suse dot cz>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 27 Jun 2008 15:07:50 -0400
Subject: Re: [PATCH]: Get IPA PTA working again
References: <4aca3dc20806270910h62eee773gc170f9c7573d42f8@mail.gmail.com> <20080627182159.GB11847@kam.mff.cuni.cz>

On Fri, Jun 27, 2008 at 2:21 PM, Jan Hubicka <jh@suse.cz> wrote:
>> This makes IPA pta stop crashing due to stmts being marked as modified.
>>
>>
>> Jan, maybe you could explain to me why the TODO_update_ssa we have in
>> the todo_finish flags doesn't make this work?
>
> TODO_update_ssa ought to trigger updating on all function bodies.  How
> does it fails for you?

TODO_update_ssa should also end up marking all the statements as not
modified because it calls update_stmt.

We have TODO_update_ssa in the finish flags of ipa_pta, but it either
isn't running, or verifier is verifying each function individually
before running finish flag.

The symptom is that if you remove the patch i just committed, it will
complain that we have marked statements modified.

Follow-Ups:
- Re: [PATCH]: Get IPA PTA working again
  - From: Jan Hubicka

References:
- [PATCH]: Get IPA PTA working again
  - From: Daniel Berlin
- Re: [PATCH]: Get IPA PTA working again
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]