This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, middle-end]: Fix PR 36584, Stack is not aligned correctly in recursive function
- From: "Richard Guenther" <richard dot guenther at gmail dot com>
- To: "Uros Bizjak" <ubizjak at gmail dot com>
- Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>, "Jan Hubicka" <jh at suse dot cz>
- Date: Sat, 21 Jun 2008 17:51:07 +0200
- Subject: Re: [PATCH, middle-end]: Fix PR 36584, Stack is not aligned correctly in recursive function
- References: <485D00A0.2060001@gmail.com> <485D127C.90700@gmail.com>
On Sat, Jun 21, 2008 at 4:38 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> Uros Bizjak wrote:
>
>> 2008-06-21 Uros Bizjak <ubizjak@gmail.com>
>>
>> PR middle-end/PR36584
>> * calls.c (expand_call): Increase alignment for recursive functions.
>>
>> testsuite/ChangeLog:
>>
>> 2008-06-21 Uros Bizjak <ubizjak@gmail.com>
>>
>> PR middle-end/PR36584
>> * testsuite/gcc.dg/pr36584.c: New test.
>>
>>
>> Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu. OK
>> for mainline and 4.3?
>
> I forgot to mention that gcc.target/i386/local2.c test that tests on i386
> for this invalid optimization should be removed.
IMHO the patch looks obvious and this optimization is invalid. But as
I'm curious - can
you try to dig in the history to for what reason it was added?
The patch is nevertheless ok.
Thanks,
Richard.