This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ warnings vs. errors
On Thu, Jun 19, 2008 at 5:08 PM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> 2008/6/18 Mark Mitchell:
>>> * I don't think the pedwarn in joust() in cp/call.c should be a
>>> permerror, is this a GNU extension?
>>> if (warn)
>>> {
>>> pedwarn ("\
>>> ISO C++ says that these are ambiguous, even \
>>> though the worst conversion for the first is better than \
>>> the worst conversion for the second:");
>>> print_z_candidate (_("candidate 1:"), w);
>>> print_z_candidate (_("candidate 2:"), l);
>>> }
>>
>> Yes, that is a historical GNU extension. I think this should just be a
>> warning, given that the whole section of code is guarded with !pedantic.
>
> OK. Should I also get rid of the escaped newlines and rely on string
> concatenation for the text?
yes, please.
>
> Jon
>
>
>
>
>>> * I don't know if these in cp/typeck.c should be permerrors, DTRT
>>> implies not, but should tf_error be changed to tf_warning?
>>
>> I think "DTRT" here means "do what whoever wrote this code thinks the
>> standard should say" not "do what the standard says". Please make these
>> permerrors.
>>
>> Thanks,
>>
>> --
>> Mark Mitchell
>> CodeSourcery
>> mark@codesourcery.com
>> (650) 331-3385 x713
>>
>>
>