This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [c++0x] Patch for std::next/prev
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Chris Fairles <chris dot fairles at gmail dot com>, gcc-patches at gcc dot gnu dot org, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 17 Jun 2008 16:07:17 -0500 (CDT)
- Subject: Re: [c++0x] Patch for std::next/prev
- Accept-language: en-US
- References: <fac6bb500806170918w68cba64nc26ca6657f554554@mail.gmail.com>
Hi,
--- Original Message ---
> Implemented based on N2606. Test cases provided.
Looks mostly good, many thanks, I'll commit it asap. For your next contributions a few minor nits:
1- Uglify, always uglify, forever (I hope not ;) uglify: n -> __n , x -> __x, etc.
2- Always wrap to 80 columns
3- Watch the indentations, each is always 2 spaces wide in our codebase.
4- Remember the test variable in testcases (a long story but goes with the VERIFY dance)
5- As a stylistic matter, the main in the testcases always ends with return 0;
6- In general, each testfile includes *1* test function and main (much easier to deal with fails on exotic targets)
7- Last but not least, *never* fiddle with the headers! I.e., never leave out the
// Copyright (C) 2008 Free Software Foundation, Inc.
line.
Thanks again,
Paolo.