This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR preprocessor/33305: Warn for empty macro arguments

From: "Andrew Haley" <aph@redhat.com>

Joseph S. Myers wrote: 
Also, such a diagnostic should be restricted to -pedantic if your patch
doesn't so restrict it, and needs testcases.


I can do that.  I don't agree that it should be restricted to -pedantic.
Why do you think it should be?

Because users who don't care about ISO C90 compatibility will consider this warning to be noise. I would recommend doing something like the -Wlong-long flag, where -pedantic activates it by default but -Wno-long-long can selectively turn it off. GCC already uses -pedantic, so no additional bootstrap flags would be necessary.

Maybe call it -Wempty-macro-args ?

--Kaveh

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]