This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, committed] Fix config.gcc shell lossage
- From: Andreas Schwab <schwab at suse dot de>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Michael Meissner <michael dot meissner at amd dot com>, gcc-patches at gcc dot gnu dot org, christophe dot harle at amd dot com
- Date: Tue, 10 Jun 2008 19:25:38 +0200
- Subject: Re: [PATCH, committed] Fix config.gcc shell lossage
- References: <20080609162203.GA11510@mmeissner-gold.amd.com> <m3tzg1i5kg.fsf@google.com>
Ian Lance Taylor <iant@google.com> writes:
> Michael Meissner <michael.meissner@amd.com> writes:
>
>> - if test $enable_cld = yes; then
>> + if test "x$enable_cld" = xyes; then
>
> I'll just note that you don't need to use both a prefix and
> doublequotes. Either one alone suffices.
Unless $enable_cld can contain whitespace, which it can.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."