This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix stack usage of SCCVN, PR35204
- From: "Richard Guenther" <richard dot guenther at gmail dot com>
- To: "Richard Guenther" <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, "Daniel Berlin" <dberlin at dberlin dot org>
- Date: Tue, 20 May 2008 22:38:31 +0200
- Subject: Re: [PATCH] Fix stack usage of SCCVN, PR35204
- References: <Pine.LNX.4.64.0802191256380.5150@zhemvz.fhfr.qr>
On Tue, Feb 19, 2008 at 1:59 PM, Richard Guenther <rguenther@suse.de> wrote:
>
> The DFS walk in SCCVN is done recursively and is in some cases such as
> PR35204 using up more than the soft stack size limit on x86_64-linux,
> which is 8MB. This patch addresses this by not recursing, but keeping
> multiple SSA use iterators on a heap allocated stack instead.
>
> The patch doesn't show adverse effects on compile-time or memory usage
> when applied to our daily testers of SPEC & friends.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
>
> Ok for mainline?
I re-tested this on x86_64-unknown-linux-gnu and commited it to trunk
now, bootstrap
finished on the 4.3 branch and testing is still running. I plan to
commit it there, too,
before 4.3.1 as requested.
Thanks,
Richard.
> Thanks,
> Richard.
>
> 2008-02-16 Richard Guenther <rguenther@suse.de>
>
> PR tree-optimization/35204
> * tree-ssa-sccvn.c (extract_and_process_scc_for_name): New
> helper, split out from ...
> (DFS): ... here. Make the DFS walk non-recursive.