This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PR testsuite/35647


Hi,
while testing my patch to remove tree dumps I noticed two xpasses in
cmdlne tests.  Previously we mistakely interpretted options like -dM and
-dI as RTL dump _and_ preprocesor debug directives at once.  I assumed
that the testcase got fixed by removing the RTL dump code patch and
removed xfail.  It turns out that those testcases fails for about
everyone else except me, so returning the xfail seems to be good idea.
What precisely is this test testing (ie what others get on output so the
testcase fails?)

Anyway the attached patch reverts the change. OK to commit?

Honza

	PR testsuite/35647
	* gcc.dg/cpp/cmdlne-dI-M.c: Revert my previous patch.
	* gcc.dg/cpp/cmdlne-dM-M.c: Revert my previous patch.
Index: testsuite/gcc.dg/cpp/cmdlne-dI-M.c
===================================================================
*** testsuite/gcc.dg/cpp/cmdlne-dI-M.c	(revision 133342)
--- testsuite/gcc.dg/cpp/cmdlne-dI-M.c	(working copy)
*************** int variable;
*** 13,16 ****
  
  /* { dg-final { scan-file-not cmdlne-dI-M.i "(^|\\n)#define foo bar($|\\n)" } }
     { dg-final { scan-file-not cmdlne-dI-M.i "variable" } }
!    { dg-final { scan-file cmdlne-dI-M.i "(^|\\n)cmdlne-dI-M.*:\[^\\n\]*cmdlne-dI-M.c" } } */
--- 13,16 ----
  
  /* { dg-final { scan-file-not cmdlne-dI-M.i "(^|\\n)#define foo bar($|\\n)" } }
     { dg-final { scan-file-not cmdlne-dI-M.i "variable" } }
!    { dg-final { scan-file cmdlne-dI-M.i "(^|\\n)cmdlne-dI-M.*:\[^\\n\]*cmdlne-dI-M.c" { xfail *-*-* } } } */
Index: testsuite/gcc.dg/cpp/cmdlne-dM-M.c
===================================================================
*** testsuite/gcc.dg/cpp/cmdlne-dM-M.c	(revision 133342)
--- testsuite/gcc.dg/cpp/cmdlne-dM-M.c	(working copy)
*************** int variable;
*** 12,15 ****
  
  /* { dg-final { scan-file cmdlne-dM-M.i "(^|\\n)#define foo bar($|\\n)" } }
     { dg-final { scan-file-not cmdlne-dM-M.i "variable" } }
!    { dg-final { scan-file cmdlne-dM-M.i "(^|\\n)cmdlne-dM-M\[^\\n\]*:\[^\\n\]*cmdlne-dM-M.c"} } */
--- 12,15 ----
  
  /* { dg-final { scan-file cmdlne-dM-M.i "(^|\\n)#define foo bar($|\\n)" } }
     { dg-final { scan-file-not cmdlne-dM-M.i "variable" } }
!    { dg-final { scan-file cmdlne-dM-M.i "(^|\\n)cmdlne-dM-M\[^\\n\]*:\[^\\n\]*cmdlne-dM-M.c" { xfail *-*-* } } } */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]