This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Teach SCCVN/FRE expression insertion, optimize type-punning through unions (final!)

From: Paolo Bonzini <bonzini at gnu dot org>
To: Richard Guenther <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org, Daniel Berlin <dberlin at dberlin dot org>
Date: Fri, 14 Mar 2008 13:03:23 +0100
Subject: Re: [PATCH] Teach SCCVN/FRE expression insertion, optimize type-punning through unions (final!)
References: <Pine.LNX.4.64.0803141153250.4133@zhemvz.fhfr.qr>

+ 	*state_in = fs.reg;
+ 	*state_in = fs.offset;

Better to write to two different variables, maybe?

+     union loc fs;
+     for (;;)
+     {
+ 	*state_in = fs.offset;
+ 	*state_in = fs.reg;

Likewise, and also make them volatile?

+ 	    case 0:
+ 		*state_in = fs.reg;
+ 	    case 1:
+ 		*state_in = fs.offset;

Write to two variables here too?

Paolo

Follow-Ups:
- Re: [PATCH] Teach SCCVN/FRE expression insertion, optimize type-punning through unions (final!)
  - From: Richard Guenther

References:
- [PATCH] Teach SCCVN/FRE expression insertion, optimize type-punning through unions (final!)
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]