Re: [PATCH, i386]: Fix PR target/35553, -fkeep-inline-functions and -O errors our in SSE headers

["Richard Guenther" <richard dot guenther at gmail dot com>]

On Thu, Mar 13, 2008 at 11:18 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
>
>  >  >  Fixed by introducing __SSE_USE_INLINED_FUNC__ builtin define that is
>  >  >  defined when appropriate and by using this define through SSE headers.
>  >
>  >  Why not simply make these functions extern inline __attribute__((gnu_inline))?
>
>  Huh, indeed.
>
>  Do we need extern here or can go with static inline
>  __attribute__((gnu_inline, _always_inline_))
>
>  (the tests that redefine "static" won't have to be updated in this case.)

I don't know how we mix gnu_inline and static here, especially with
-fkeep-inline-functions, so you'd have to try.  But extern inline is
the semantics we want (any out-of-line copy will be bogus, so you
also could say that keeping always_inline functions is bogus
with -fkeep-inline-functions - you might want to do some research
why we do so and maybe fix that instead).

Thanks,
Richard.