This is the mail archive of the
mailing list for the GCC project.
Re: [c++0x] <date_time> implementation, take 2
- From: Paolo Carlini <pcarlini at suse dot de>
- To: Pedro LamarÃo <pedro dot lamarao at mndfck dot org>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 10 Mar 2008 13:41:22 +0100
- Subject: Re: [c++0x] <date_time> implementation, take 2
- References: <47D4B651.firstname.lastname@example.org>
I have some additional general comments, sorry for not telling you at
once. I'm sure that next time everything will be *much* faster ;)
> Here goes. The patch was generated with svn diff.
> It defines get_system_time using std::time; we can add support for
> more precise stuff later.
Seems a good idea, as a nit please call with std::time.
> Attached in a tarball is a testsuite for std::nanoseconds and
Great. In general we are always using -std=gnu++0x, in the tests.
> 2008-03-10 Pedro LamarÃo <email@example.com>
> * include/std/date_time: new file.
> * src/date_time.cpp: new file.
> * config/abi/pre/gnu.ver: get_system_time is a new symbol
> in version GLIBCXX_3.4.11.
> * include/Makefile.am: add date_time in std headers.
> * src/Makefile.am: add date_time.cc to source files.
It looks like definitions are missing for the various static constants.
Also, remember that all the symbols used in the implementation must be
"uglified", typically with double underscore in front or single in case
of types, template parameters, have a look to the existing code for