Re: [PATCH][mem-ref] Adjust some testsuite patterns

[Richard Guenther <rguenther at suse dot de>]

On Sun, 9 Mar 2008, Andrew Pinski wrote:

> Hi,
>   Some comments/questions.
> 
> >  ! /* { dg-final { scan-tree-dump-times "MEM <float " 3 "optimized" } } */
> >  ! /* { dg-final { scan-tree-dump-times "\\\&a \\\+ 4" 1 "optimized" } } */
> >   /* { dg-final { cleanup-tree-dump "optimized" } } */
> 
> We should not be taking the address of a here.  This is not a false
> positive at all.  REALPART_EXPR/IMAGPART_EXPR should not require the
> address of the variable taken.  Right?  If you do now, then I think
> you need to think that as we really don't want extra addressable
> variables on the rtl level.  Now if we don't fold it to
> REALPART_EXPR/IMAGPART_EXPR, then something is really wrong and the
> testcase should not be changed at all.

You are right, I have reverted that change.

Thanks for noticing.

I also deleted the two foldaddr testcases.

Richard.