This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] contrib/patch_tester.sh, 7 of 7
- From: "Sebastian Pop" <sebpop at gmail dot com>
- To: janis187 at us dot ibm dot com
- Cc: gcc-patches at gcc dot gnu dot org, tromey at redhat dot com
- Date: Fri, 7 Mar 2008 11:43:41 -0600
- Subject: Re: [PATCH] contrib/patch_tester.sh, 7 of 7
- References: <1204761552.6363.40.camel@janis-laptop>
On Wed, Mar 5, 2008 at 5:59 PM, Janis Johnson <janis187@us.ibm.com> wrote:
> This patch to contrib/patch_tester.sh verifies that at least one set of
> tests was run. Otherwise a bad value for check options could cause the
> testsuite run to be skipped but the patch would be reported to have
> caused no regressions.
>
> Sebastian, OK for trunk?
>
Yes thanks.
> --- patch_tester.sh.6 2008-03-05 15:29:36.000000000 -0800
> +++ patch_tester.sh 2008-03-05 15:29:39.000000000 -0800
> @@ -316,6 +316,12 @@ bootntest () {
> CHECK_OPTIONS=`grep "^check:" $PATCH | sed -e "s/^check://g"`
> eval make $dashj $CHECK_OPTIONS -k check &> $1/check
>
> + SUITESRUN="`grep 'Summary ===' $1/check | cut -d' ' -f 2 | sort`"
> + if [ x$SUITESRUN = x ]; then
> + report "check with `basename $1` version failed, no testsuites were run"
> + return 1
> + fi
> +
> for LOG in $TESTLOGS ; do
> if [ -f $BUILD/$LOG ]; then
> mv $BUILD/$LOG $1
>
>
>
--
Sebastian
AMD - GNU Tools