This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR tree-optimization/35494: [4.4 Regression]: Revision 132991 breaks 483.xalancbmk


On Fri, Mar 7, 2008 at 4:30 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Mar 07, 2008 at 04:19:01PM +0100, Richard Guenther wrote:
>  > On Fri, Mar 7, 2008 at 4:00 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>  > > We can't fold glocal variables with NULL DECL_INITIAL. I am testing it
>  > >  on Linux/x86 and Linux/Intel64 as well as 483.xalancbmk. OK to install
>  > >  if all pass?
>  >
>  > Hm, use targetm.binds_local_p instead?
>  >
>
>  I don't think targetm.binds_local_p is appropriate here.
>  targetm.binds_local_p tells me if a symbol is local to
>  the module, which may consist of many files, and a symbol
>  local to the module may be initialized to a different value
>  in another file.  But here we want to check if a symbol local
>  to the file.

The patch is ok then if testing passes.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]