This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] BIT_FIELD_REF_UNSIGNED considered harmful


On 03/05/08 07:18, Richard Guenther wrote:

Comments?

Makes sense to me.


+ 	      if (INTEGRAL_TYPE_P (TREE_TYPE (t))
+ 		  && (TYPE_PRECISION (TREE_TYPE (t))
+ 		      != TREE_INT_CST_LOW (TREE_OPERAND (t, 1))))
+ 		{
+ 		  error ("integral result type precision does not match "
+ 			 "field size of BIT_FIELD_REF");
+ 		  return t;
+ 		}
+ 	      if (!INTEGRAL_TYPE_P (TREE_TYPE (t))

'else if' here?




Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]