This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.3/4.4]: PATCH: PR target/35453: nmmintrin.h defines macros SIDD_XXX
- From: Richard Guenther <rguenther at suse dot de>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Tue, 4 Mar 2008 19:57:34 +0100 (CET)
- Subject: Re: [4.3/4.4]: PATCH: PR target/35453: nmmintrin.h defines macros SIDD_XXX
- References: <47CD9B36.7040305@gmail.com>
On Tue, 4 Mar 2008, Uros Bizjak wrote:
> Hello!
>
> > 2008-03-03 H.J. Lu <hongjiu.lu@intel.com>
> >
> > PR target/35453
> > * config/i386/smmintrin.h (SIDD_XXX): Renamed to ...
> > (_SIDD_XXX): This.
> >
> > gcc/testsuite/
> >
> > 2008-03-03 H.J. Lu <hongjiu.lu@intel.com>
> >
> > PR target/35453
> > * gcc.target/i386/sse4_2-pcmpestri-1.c: Replace SIDD_XXX with
> > _SIDD_XXX.
> > * gcc.target/i386/sse4_2-pcmpestri-2.c: Likewise.
> > * gcc.target/i386/sse4_2-pcmpestrm-1.c: Likewise.
> > * gcc.target/i386/sse4_2-pcmpestrm-2.c: Likewise.
> > * gcc.target/i386/sse4_2-pcmpistri-1.c: Likewise.
> > * gcc.target/i386/sse4_2-pcmpistri-2.c: Likewise.
> > * gcc.target/i386/sse4_2-pcmpistrm-1.c: Likewise.
> > * gcc.target/i386/sse4_2-pcmpistrm-2.c: Likewise.
> > * gcc.target/i386/sse4_2-pcmpstr.h: Likewise.
>
> This patch is OK for mainline. I would vote to get this patch into 4.3 branch
> before releasing 4.3.0, since it is needed for compatibility with a de-facto
> standard compiler and it avoids compatibility problems between 4.3.0 and 4.3.x
> (or 4.4.x). Also, this is a mechanical rename patch without any
> destabilization impact.
This is ok for the branch.
Richard.