This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, testsuite]: Add -fno-asynchronous-unwind-tables to -freorder-blocks-and-partition tests


On Sun, Mar 2, 2008 at 1:06 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
>  Since -freorder-blocks-and-partition creates invalid DWARF2 unwind
>  tables [1] (in addition that this option doesn't work with exceptions),
>  attached patch adds -fno-asynchronous-unwind-tables to dg-options for
>  the testcases where -freorder-blocks-and-partition is used.

Err, shouldn't this bug be fixed instead instead of "fixing" the testcases?

Richard.

>  2008-03-02  Uros Bizjak  <ubizjak@gmail.com>
>
>         * gcc.dg/tree-prof/bb-reorg.c: Add -fno-asynchronous-unwind-tables
>         to dg-options.
>         * gcc.dg/tree-prof/pr34999.c: Ditto.
>
>  Attached patch was tested on x86_64-pc-linux-gnu {,-m32}. OK for
>  mainline and branches?
>
>  [1]: http://gcc.gnu.org/PR34999
>
>  Uros.
>
>  Index: gcc.dg/tree-prof/bb-reorg.c
>  ===================================================================
>  --- gcc.dg/tree-prof/bb-reorg.c (revision 132813)
>  +++ gcc.dg/tree-prof/bb-reorg.c (working copy)
>  @@ -1,5 +1,5 @@
>   /* { dg-require-effective-target freorder } */
>  -/* { dg-options "-O2 -freorder-blocks-and-partition" } */
>  +/* { dg-options "-O2 -freorder-blocks-and-partition
>  -fno-asynchronous-unwind-tables" } */
>
>   #include <string.h>
>
>  Index: gcc.dg/tree-prof/pr34999.c
>  ===================================================================
>  --- gcc.dg/tree-prof/pr34999.c  (revision 132813)
>  +++ gcc.dg/tree-prof/pr34999.c  (working copy)
>  @@ -1,7 +1,7 @@
>   /* Same test as built-in-setjmp.c.  Includes the case where
>     the source block of a crossing fallthru edge ends with a call.  */
>   /* { dg-require-effective-target freorder } */
>  -/* { dg-options "-O2 -freorder-blocks-and-partition" } */
>  +/* { dg-options "-O2 -freorder-blocks-and-partition
>  -fno-asynchronous-unwind-tables" } */
>
>   extern int strcmp(const char *, const char *);
>   extern char *strcpy(char *, const char *);
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]