This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,fortran]: Emit COMMON identifiers in proper debug scope
- From: FX Coudert <fxcoudert at gmail dot com>
- To: George Helffrich <george at w170 dot demon dot co dot uk>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Sat, 23 Feb 2008 12:14:35 +0000
- Subject: Re: [PATCH,fortran]: Emit COMMON identifiers in proper debug scope
- References: <590fb41a865520b67a32f87094b6468c@w170.demon.co.uk>
+2007-10-27 George Helffrich <ghfbsd@gly.bris.ac.uk>
+
+ * trans-common.c (create_common): Identifiers declared in
COMMON
+ go on to the function's decl chain, not the global chain.
This makes
+ the symbols appear in the proper debug scope.
I've looked more into it, and I'm now convinced that this patch is in
principle OK: commons shouldn't be put on toplevel scope. One thing,
though, is that in practice applying this patch makes stabs work
better, but makes us regress on DWARF targets (where having commons
at global scope hid the preexsiting issue): see http://gcc.gnu.org/ml/
gcc-patches/2007-10/msg01685.html for details.
Thus, I okay this patch conditional to the fix to dwarf2out being
committed at the same time. So, can you make a combined patch (this
one + the latest version of the dwarf2out patch), submit it and CC
the dwarf or debug-info maintainer (Jim Wilson and Jason Merrill)?
Thanks,
FX
--
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/