This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tuples] Write locus for the correct sequence


On Wed, Feb 20, 2008 at 03:26:41PM -0800, Oleg Ryjkov wrote:
> Fix a bug in gimplify.c to write the location information for
> the sequence corresponding to an expr that was just gimplified.
> 
> Does not fix any tests by itself. But with
> pass_early_warn_uninitialized enabled fixed 55 tests in dg.exp.

Oops, the claim is wrong. The tests are unbroken just by this fix.

> 
> Approved by Diego.
> 
> 2008-02-20  Oleg Ryjkov  <olegr@google.com>
> 
>   * gimplify.c(gimplify_expr): Save locus into the right
>     sequence.

> Index: ChangeLog.tuples
> ===================================================================
> --- ChangeLog.tuples	(revision 132498)
> +++ ChangeLog.tuples	(working copy)
> @@ -1,3 +1,8 @@
> +2008-02-20  Oleg Ryjkov  <olegr@google.com>
> +
> +	* gimplify.c(gimplify_expr): Save locus into the right
> +	sequence.
> +
>  2008-02-19  Oleg Ryjkov  <olegr@google.com>
>  
>  	* gimple-pretty-print.c: Introduce support for TDF_RAW
> Index: gimplify.c
> ===================================================================
> --- gimplify.c	(revision 132498)
> +++ gimplify.c	(working copy)
> @@ -6429,8 +6429,8 @@ gimplify_expr (tree *expr_p, gimple_seq 
>  	  gimple_seq_add_seq (pre_p, internal_pre);
>  	}
>  
> -      if (!gimple_seq_empty_p (internal_pre))
> -	annotate_all_with_locus (internal_pre, input_location);
> +      if (!gimple_seq_empty_p (*pre_p))
> +	annotate_all_with_locus (*pre_p, input_location);
>  
>        goto out;
>      }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]