This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] Remove 'next' and 'prev' fields in gimple_statement_base
- From: Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Aldy Hernandez <aldyh at redhat dot com>
- Date: Tue, 19 Feb 2008 21:10:31 +0100
- Subject: Re: [tuples] Remove 'next' and 'prev' fields in gimple_statement_base
- References: <b798aad50802191153u1d64ea7jb82f63fbe1b8eb5a@mail.gmail.com>
Hi,
> This patch fixes several dozen testsuite failures due to mishandling
> of gimple sequences. In the initial design we had next and prev links
> inside gimple statements. This was causing grief for two reasons:
it might also have some benefits:
-- lower memory consumption
-- less indirection in accessing statements (possibly improving compile
time)
-- possibility to get iterator for statement in constant time (which is
occasionally useful, when we get the statement from
SSA_NAME_DEF_STMT, and want to work with it).
So although for the moment it is probably better to keep things simple
and consistent and make the branch work for now, it moving prev & next
back to gimple_base would probably be an useful future project,
Zdenek