This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR c++/35056] convert bitfield to target expr type for const& binding

Hi,

On Wed, 6 Feb 2008, Mark Mitchell wrote:

> > for  gcc/testsuite/ChangeLog
> > from  Alexandre Oliva  <aoliva@redhat.com>
> > 
> >  PR c++/35056
> >  * g++.dg/conversion/bitfield8.C: New.
> 
> This patch is OK.  But, I too would suggest taking the assert out for 4.3 as
> well.  I don't think we know that every time that assertion failures we have
> an actual demonstrable bug.

We have.  If the assert fails, we will in the end generate 
  slot = init;
from gimplifying the TARGET_EXPR, where the types of slot and init need a 
(now missing) conversion.  This always can be transformed into an actually 
failing testcase.  If we really don't want to risk asserting in harmless 
situations for the release, a wrapping in ENABLE_CHECKING would still be 
sensible.


Ciao,
Michael.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]