This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch i386]: For target x86_64-pc-mingw32 _alloca and _stkchk may corrupts stack alignment
- From: NightStrike <nightstrike at gmail dot com>
- To: "Kai Tietz" <Kai dot Tietz at onevision dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 4 Feb 2008 10:24:25 -0500
- Subject: Re: [patch i386]: For target x86_64-pc-mingw32 _alloca and _stkchk may corrupts stack alignment
- References: <OF79B2E662.E2FF6F42-ONC12573DE.00567D65-C12573DE.00569824@onevision.de>
On 1/28/08, Kai Tietz <Kai.Tietz@onevision.com> wrote:
> Hi,
>
> This patch fixes two problems for the target x86_64-pc-mingw32 in _alloca
> and a possible problem in _stkchk. The stack alignment on 64-bit Windows
> needs to be on 8 bytes. Otherwise a general exception will be raised. This
> can certain happen for _alloca and may for _chkstk. The other problem is
> that _alloca implementation for _WIN64 does not take care about the
> parameter stack reservation of abi. This leads to a wrong stack pointer.
>
> ChangeLog:
>
> 2008-01-28 Kai Tietz <kai.tietz@onevision.com>
>
> * gcc/config/i386/cygwin.asm: (__alloca): Correct calling
> convention and alignment.
> (__chkstk): Force 8 byte stack alignment.
>
> Is this fix OK for apply on mainline?
Was this applied to mainline gcc yet?