This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix compilation error in libbid
- From: Bernhard Fischer <rep dot dot dot nop at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: hjl at lucon dot org, rep dot dot dot nop at gmail dot com
- Date: Sat, 15 Dec 2007 18:50:51 +0100
- Subject: Re: [PATCH] fix compilation error in libbid
- References: <20071119154038.GA451@aon.at>
ping
http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01017.html
thanks,
On Mon, Nov 19, 2007 at 04:40:38PM +0100, Bernhard Fischer wrote:
>Hi,
>
>I was getting errors due to conflicting types for __bid_convert_table et
>al ¹). Looks like it was missing a const.
>
>Untested. Hjl, please fix.
>
>Thanks,
>
>libgcc/ChangeLog:
>
>2007-11-19 Bernhard Fischer <aldot>
>
> * (config/libbid/bid64_div.c): Also extern decl of
> __bid_{convert_table,factors,packed_10000_zeros} have to be const.
>
>
>
>¹)
>../../../../src/gcc-4.3/libgcc/config/libbid/bid64_div.c:1369: error:
>conflicting types for '__bid_convert_table'
>../../../../src/gcc-4.3/libgcc/config/libbid/bid64_div.c:69: error:
>previous declaration of '__bid_convert_table' was here
>../../../../src/gcc-4.3/libgcc/config/libbid/bid64_div.c:1370: error:
>conflicting types for '__bid_factors'
>../../../../src/gcc-4.3/libgcc/config/libbid/bid64_div.c:70: error:
>previous declaration of '__bid_factors' was here
>../../../../src/gcc-4.3/libgcc/config/libbid/bid64_div.c:1371: error:
>conflicting types for '__bid_packed_10000_zeros'
>../../../../src/gcc-4.3/libgcc/config/libbid/bid64_div.c:71: error:
>previous declaration of '__bid_packed_10000_zeros' was here
>make[3]: *** [bid64_div.o] Error 1
>
>libgcc/ChangeLog:
>
>2007-11-19 Bernhard Fischer <aldot>
>
> * (config/libbid/bid64_div.c): Also extern decl of
> __bid_{convert_table,factors,packed_10000_zeros} have to be const.
>
>Index: gcc-4.3/libgcc/config/libbid/bid64_div.c
>===================================================================
>--- gcc-4.3/libgcc/config/libbid/bid64_div.c (revision 130291)
>+++ gcc-4.3/libgcc/config/libbid/bid64_div.c (working copy)
>@@ -66,9 +66,9 @@
> #define FE_ALL_FLAGS FE_INVALID|FE_DIVBYZERO|FE_OVERFLOW|FE_UNDERFLOW|FE_INEXACT
> #endif
>
>-extern UINT32 convert_table[5][128][2];
>-extern SINT8 factors[][2];
>-extern UINT8 packed_10000_zeros[];
>+extern const UINT32 convert_table[5][128][2];
>+extern const SINT8 factors[][2];
>+extern const UINT8 packed_10000_zeros[];
>
>
> #if DECIMAL_CALL_BY_REFERENCE
>@@ -1366,11 +1366,6 @@
>
> //#define LEAVE_TRAILING_ZEROS
>
>-extern UINT32 convert_table[5][128][2];
>-extern SINT8 factors[][2];
>-extern UINT8 packed_10000_zeros[];
>-
>-
> //UINT64* bid64_div128x128(UINT64 res, UINT128 *px, UINT128 *py, unsigned rnd_mode, unsigned *pfpsf)
>
> TYPE0_FUNCTION_ARG128_ARG128 (UINT64, bid64qq_div, x, y)