This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] Fix -frepo (PR c++/34178, c++/34340, take 3)

Jakub Jelinek wrote:

> That seems to work too, for make check-g++ at least (but there are just
> very few -frepo testcases, which is probably why this could be broken for so
> long).

> 	PR c++/34178
> 	PR c++/34340
> 	* repo.c (repo_emit_p): Return 2 for DECL_INTEGRAL_CONSTANT_VAR_P
> 	in class scope rather than DECL_INITIALIZED_BY_CONSTANT_EXPRESSION_P.
> 	Return 2 also if DECL_EXPLICIT_INSTANTIATION.
> 	* decl2.c (import_export_decl): Don't make VAR_DECLs import_p when
> 	flag_use_repository and repo_emit_p returned 2.
> 
> 	* g++.dg/template/repo6.C: New test.
> 	* g++.dg/template/repo7.C: New test.
> 	* g++.dg/template/repo8.C: New test.

If Jason doesn't object within 24 hours, please go ahead and put this
in.  This seems sensible (at least to me!) so I think it's worth a try.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]