This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Fix -frepo (PR c++/34178, take 2)
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 05 Dec 2007 17:03:29 -0800
- Subject: Re: [C++ PATCH] Fix -frepo (PR c++/34178, take 2)
- References: <20071127215831.GX16835@devserv.devel.redhat.com> <20071205151120.GA25112@devserv.devel.redhat.com>
Jakub Jelinek wrote:
> 2007-12-05 Jakub Jelinek <jakub@redhat.com>
>
> PR c++/34178
> * repo.c (repo_emit_p): Return 2 for
> DECL_INITIALIZED_BY_CONSTANT_EXPRESSION_P decls only if they are
> const.
Why don't we want to use DECL_INTEGRAL_CONSTANT_VAR_P here?
> * decl2.c (import_export_decl): Don't make VAR_DECLs import_p when
> flag_use_repository and repo_emit_p returned 2.
> + if ((flag_implicit_templates
> + && !flag_use_repository)
Shouldn't that condition involve emit_p, rather than just be
!flag_use_repository?
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713