This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] ada: Fix crash with deeply inherited function
- From: Arnaud Charlet <charlet at adacore dot com>
- To: Samuel Tardieu <sam at rfc1149 dot net>
- Cc: gcc-patches at gcc dot gnu dot org, Ed Schonberg <schonberg at adacore dot com>
- Date: Wed, 5 Dec 2007 09:25:13 +0100
- Subject: Re: [PATCH] ada: Fix crash with deeply inherited function
- References: <20071203173227.CDF52C405E@mail2.rfc1149.net>
> gcc/ada/
> PR ada/34149
> * exp_ch3.adb (Make_Controlling_Function_Wrappers): Ignore
> primitive operations that have just been created and not yet
> analyzed.
Here is Ed's review of your change:
There is an order-of-elaboration problem here, but the suggested fix does not
seem to be correct. It disables the creation of function wrappers for
inherited functions of null extensions in some casess that crash the front-end,
but the patch does not create those wrappers at all. The proper fix would
require that we find the original function that is being inherited multiple
times, and create a wrapper for it.
Arno