This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000]: reject -m64 and -m32 simultaneously
On 11/26/07, Ben Elliston <bje@au1.ibm.com> wrote:
> On Mon, 2007-11-26 at 21:31 -0800, Mark Mitchell wrote:
>
> > > I think we do have a rule that every option should be overrideable
> > > later. I can certainly see someone creating a shell script that does
> > > 'cc -m64' and later wanting to add with -m32.
> >
> > I think we have that rule too, or at least I think we should have it.
>
> Agreed.
>
> Given that Jakub's suggestion yields this behaviour, I'm committing the
> following patch. I am assuming that the patch is sufficiently obvious
> (and is an obvious improvement over the patch that David previously
> approved).
>
> Please hit me over the knuckles if you disagree. :-)
>
> Ben
>
>
> 2007-11-27 Ben Elliston <bje@au.ibm.com>
>
> * config/rs6000/sysv4.opt (m32): Add Negative(m64).
> (m64): Add Negative(m32).
> * config/rs6000/darwin.opt (m32): Add Negative(m64).
> (m64): Add Negative(m32).
You forgot to change aix64.opt too, maix64/maix32 .
Thanks,
Andrew Pinski