This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR33317 CSHIFT/EOSHIFT: Rejects optional dummy for DIM=


Jerry DeLisle wrote:
:ADDPATCH fortran:

This patch fixes this bug by enabling the DIM argument for these two functions in their respective check routines.

Then in resolve.c, the DIM argument is marked so that later in trans-intrinsic.c, the type can be cast to the default integer size so that it matches with the respective runtime library function.

The previous insertion of the type conversion was messing up the translation causing a segfault when a NULL (DIM argument not present) in the calling routine optional argument was not present. See test case for example.

Also fixed up some white space problems found along the way.

Regression tested on x86-64. OK for trunk?


Ignore the changes in trans-decl.c shown in the patch. Thats for another bug I was looking at. Sorry for getting that mixed in. It has no bearing on this bug here.


Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]