This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch,fortran] PR31608 again - wrong types in character array/scalar binop


:REVIEWMAIL:

Paul Richard Thomas wrote:
> 2007-11-16  Paul Thomas  <pault@gcc.gnu.org>
> 	PR fortran/31608
> 	* trans-array.c (gfc_conv_expr_descriptor): Remove exception
> 	for indirect references in the call to gfc_trans_scalar_assign.
> 	* trans-expr.c (gfc_conv_string_parameter): Instead of asserting
> 	that the expression is not an indirect reference, cast it to a
> 	pointer type of the length given by se->string_length.
>
>
> Regtested on Cygwin_NT and to be put through the mill tonight on x86_ia64/FC5.
> OK for trunk?
>   
I just bootstrapped GCC including the option --enable-checking=yes,types
and did a make check-gfortran without failures.

As the patch also looks clean: OK for the trunk.

Thanks for fixing,

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]